Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔉 [RUMF-1351] retry: add extra context to queue full log #1714

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Aug 31, 2022

Motivation

Differentiate queue full cases

Changes

Add different reason to the log

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner August 31, 2022 14:18
@codecov-commenter
Copy link

Codecov Report

Merging #1714 (50c4c1f) into main (cc58e11) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main    #1714   +/-   ##
=======================================
  Coverage   90.98%   90.98%           
=======================================
  Files         129      129           
  Lines        4914     4914           
  Branches     1091     1091           
=======================================
  Hits         4471     4471           
  Misses        443      443           
Impacted Files Coverage Δ
...ckages/core/src/transport/sendWithRetryStrategy.ts 98.83% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan force-pushed the bcaudan/retry-log branch from eafac47 to 50c4c1f Compare August 31, 2022 15:04
@bcaudan bcaudan merged commit 1754446 into main Aug 31, 2022
@bcaudan bcaudan deleted the bcaudan/retry-log branch August 31, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants