🐛 [RUMF-1372] Should not set rule_psr if it is not defined by the user
#1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
reviewed
Aug 26, 2022
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bastien Caudan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
+ Coverage 90.85% 90.87% +0.01%
==========================================
Files 128 128
Lines 4812 4811 -1
Branches 1071 1072 +1
==========================================
Hits 4372 4372
+ Misses 440 439 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bcaudan
reviewed
Aug 26, 2022
| expect(traceInfo.rule_psr).toBeUndefined() | ||
| }) | ||
|
|
||
| it('should define rule_psr to 0 if tracingSampleRate is set to 0', () => { |
bcaudan
reviewed
Aug 26, 2022
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts
Outdated
Show resolved
Hide resolved
bcaudan
approved these changes
Aug 26, 2022
added 2 commits
August 26, 2022 11:24
…taDog/browser-sdk into william/only-send-rule_psr-if-defined
BenoitZugmeyer
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We make a distinction between user set settings and default settings. By sending
rule_psreven when the user has not set it, we loose that distinction.Changes
Set
rule_psrto undefined when it is not present, thus omiting it during stringificationTesting
I have gone over the contributing documentation.