🐛 Fix instrumention of null function with 3rd party wrapper (#1570) #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simple solution for #1570. It feels like we could also just skip wrapping anything that isn't a function on L11, and immediately returning a no-op stop, but I was less comfortable making that change.
|
|
bcaudan
reviewed
Aug 19, 2022
bcaudan
approved these changes
Aug 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #1697 +/- ##
=======================================
Coverage 90.80% 90.80%
=======================================
Files 128 128
Lines 4762 4764 +2
Branches 1061 1062 +1
=======================================
+ Hits 4324 4326 +2
Misses 438 438
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issue #1570 is causing noisy errors when wrapping a null/undefined method that also has third party wrappers.
Changes
Adds a condition when executing a wrapped function to protect against the case when we "unwrap" the function ourselves and set it to null (its previous value).
Testing
I have gone over the contributing documentation.