-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡[RUMF-1344] Serialize scroll positions only for full snapshots #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
force-pushed
the
bcaudan/remove-scroll
branch
from
August 3, 2022 14:32
82b9474
to
a930fa1
Compare
Codecov Report
@@ Coverage Diff @@
## main #1670 +/- ##
=======================================
Coverage 90.71% 90.72%
=======================================
Files 127 127
Lines 4696 4699 +3
Branches 1051 1052 +1
=======================================
+ Hits 4260 4263 +3
Misses 436 436
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bcaudan
force-pushed
the
bcaudan/remove-scroll
branch
4 times, most recently
from
August 4, 2022 16:03
c80d00e
to
9f2febf
Compare
bcaudan
changed the title
⚡[RUMF-1344] Improve scroll positions recording performance
⚡[RUMF-1344] Serialize scroll positions only for full snapshots
Aug 5, 2022
bcaudan
force-pushed
the
bcaudan/remove-scroll
branch
from
August 5, 2022 13:03
9f2febf
to
eca9052
Compare
on safari 12, scroll attributes do not seem to be on html node...
bcaudan
force-pushed
the
bcaudan/remove-scroll
branch
from
August 5, 2022 13:23
eca9052
to
3f701c4
Compare
4 tasks
liywjl
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
packages/rum-core/src/domain/rumEventsCollection/view/trackViewMetrics.spec.ts
Show resolved
Hide resolved
BenoitZugmeyer
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Accessing scroll positions of DOM elements during serialization is costly so let's avoid to do it when we can.
Changes
First step, when serializing:
Follow up in next PR:
Testing
I have gone over the contributing documentation.