✨ [RUMF-1306] Send the tracing sample rate in _dd.rule_psr for resources #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1669 +/- ##
=======================================
Coverage 90.85% 90.86%
=======================================
Files 128 128
Lines 4777 4782 +5
Branches 1067 1067
=======================================
+ Hits 4340 4345 +5
Misses 437 437
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added 2 commits
August 3, 2022 12:45
…ss-sample-rate-to-rum-context
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.spec.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Aug 3, 2022
liywjl
changed the title
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Aug 9, 2022
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts
Outdated
Show resolved
Hide resolved
BenoitZugmeyer
approved these changes
Aug 23, 2022
bcaudan
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to be able to display the sample rate on RUM BE
Changes
Pull
sampleRateout ofconfigurationand set it to therumContextunder_dd.rule_psrif presentUpdated Schema
DataDog/rum-events-format#83
Testing
I have gone over the contributing documentation.