-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REPLAY-898] Recording Frustration signals (dead, error & rage clicks) for session replay #1632
[REPLAY-898] Recording Frustration signals (dead, error & rage clicks) for session replay #1632
Conversation
883dff2
to
04f317c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
- Coverage 90.86% 90.61% -0.25%
==========================================
Files 129 129
Lines 4686 4712 +26
Branches 1050 1059 +9
==========================================
+ Hits 4258 4270 +12
- Misses 428 442 +14
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👏
It could be interesting to also add some e2e tests to check that:
- frustration records are created on action with frustration
- ids are matching between frustration record and mouse interaction incremental record
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 👍
packages/rum-core/src/domain/rumEventsCollection/action/actionCollection.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
fca0106
to
0ee3479
Compare
available in 4.16.0 |
Motivation
We would like to report frustration signals in form of session replay records in order to animate it on the session replay player
Changes
Recording frustration signals linked to dead, error and rage clicks for session replay.
Besides, it changes the start date of a segment to the date of earliest contained record.
Testing
On staging, the browser SDK should see that frustration records are sent.
I have gone over the contributing documentation.