-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨[RUMF-1314] Expose a DD_LOGS.getInternalContext #1626
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
reviewed
Jul 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #1626 +/- ##
==========================================
+ Coverage 90.87% 90.89% +0.01%
==========================================
Files 126 127 +1
Lines 4626 4635 +9
Branches 1034 1035 +1
==========================================
+ Hits 4204 4213 +9
Misses 422 422
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…om:DataDog/browser-sdk into william/extend-getInternalContext-for-logs
bcaudan
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice first one!
amortemousque
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want users to be able to access the
session_id
from theDD_LOGS
#390
Changes
Add
getInternalContext
method to theDD_LOGS
that currently only exposessession_id
Testing
I have gone over the contributing documentation.