Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUMF-1314] Expose a DD_LOGS.getInternalContext #1626

Merged
merged 7 commits into from
Jul 6, 2022

Conversation

liywjl
Copy link
Contributor

@liywjl liywjl commented Jul 4, 2022

Motivation

We want users to be able to access the session_id from the DD_LOGS

#390

Changes

Add getInternalContext method to the DD_LOGS that currently only exposes session_id

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bits-bot
Copy link

bits-bot commented Jul 4, 2022

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #1626 (4b47dab) into main (e54d0f8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1626      +/-   ##
==========================================
+ Coverage   90.87%   90.89%   +0.01%     
==========================================
  Files         126      127       +1     
  Lines        4626     4635       +9     
  Branches     1034     1035       +1     
==========================================
+ Hits         4204     4213       +9     
  Misses        422      422              
Impacted Files Coverage Δ
packages/logs/src/boot/logsPublicApi.ts 100.00% <100.00%> (ø)
packages/logs/src/boot/startLogs.ts 87.09% <100.00%> (+0.43%) ⬆️
packages/logs/src/domain/internalContext.ts 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

…om:DataDog/browser-sdk into william/extend-getInternalContext-for-logs
@liywjl liywjl requested review from bcaudan and amortemousque July 5, 2022 14:28
@liywjl liywjl marked this pull request as ready for review July 5, 2022 14:53
@liywjl liywjl requested a review from a team as a code owner July 5, 2022 14:53
Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first one!

packages/logs/src/boot/logsPublicApi.ts Outdated Show resolved Hide resolved
@liywjl liywjl merged commit 1f1ca4a into main Jul 6, 2022
@liywjl liywjl deleted the william/extend-getInternalContext-for-logs branch July 6, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants