🔊 Add feature flags to telemetry events #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
commented
Jul 1, 2022
Codecov Report
@@ Coverage Diff @@
## main #1625 +/- ##
=======================================
Coverage 90.87% 90.87%
=======================================
Files 126 126
Lines 4626 4627 +1
Branches 1034 1033 -1
=======================================
+ Hits 4204 4205 +1
Misses 422 422
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bcaudan
reviewed
Jul 4, 2022
| @@ -80,6 +80,7 @@ export function startTelemetry(configuration: Configuration): Telemetry { | |||
| format_version: 2 as const, | |||
| }, | |||
| telemetry: event as any, // https://github.com/microsoft/TypeScript/issues/48457 | |||
| experimental_features: getExperimentalFeatures(), | |||
There was a problem hiding this comment.
💭 thought: should not we put that on the schema?
Comment on lines
+219
to
+221
| if (arrayLike instanceof Set) { | ||
| arrayLike.forEach((item) => array.push(item)) | ||
| } else { |
There was a problem hiding this comment.
👏 praise: Nice! Things we should do to support IE...
There was a problem hiding this comment.
💬 suggestion: Remove the setToArray function from this file and replace usages with arrayFrom
BenoitZugmeyer
approved these changes
Jul 5, 2022
bcaudan
approved these changes
Jul 5, 2022
liywjl
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since we use standard feature flags (cf: https://github.com/DataDog/web-ui/pull/60432) we can now sample them.
This PR adds the enabled FF to the telemetry event to be able to filter on them.
Changes
Adds feature flag to telemetry event
Testing
I have gone over the contributing documentation.