♻️ [RUMF-1267] remove circular dependencies part 1 #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By splitting imports, we import less stuff, which removes a few cycles
Move `shouldIgnoreNode` to `privacy` module. `shouldIgnoreNode` is only used in `privacy`, so it makes sense to put it there.
Move session constants to a separate module
Move the utility function to check if an URL is a SDK bundle URL into a new utility module.
Move `flushEvents` in the `framework`, as it is both using `framework` functions and is used by the `framework`.
BenoitZugmeyer
changed the title
bcaudan
approved these changes
May 23, 2022
amortemousque
approved these changes
May 23, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the first part of removing circular dependencies in the codebase. To limit the discussion scope, I chose to do the Internal Monitoring-related changes in a speparate PR.
Changes
Testing
I have gone over the contributing documentation.