Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-1264] scrub customer frames from telemetry errors #1546

Merged
merged 3 commits into from
May 18, 2022

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented May 17, 2022

Motivation

Avoid to collect customer URLs in telemetry errors

Changes

Filter out stack trace frames that are not from:

  • empty / anonymous url
  • localhost
  • DD CDN

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan marked this pull request as ready for review May 17, 2022 16:32
@bcaudan bcaudan requested a review from a team as a code owner May 17, 2022 16:32
@codecov-commenter
Copy link

Codecov Report

Merging #1546 (9a4f6a3) into main (e57b91f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1546      +/-   ##
==========================================
+ Coverage   90.48%   90.49%   +0.01%     
==========================================
  Files         117      117              
  Lines        4479     4484       +5     
  Branches     1005     1006       +1     
==========================================
+ Hits         4053     4058       +5     
  Misses        426      426              
Impacted Files Coverage Δ
...rc/domain/internalMonitoring/internalMonitoring.ts 96.20% <100.00%> (+0.25%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bcaudan bcaudan merged commit bcc5684 into main May 18, 2022
@bcaudan bcaudan deleted the bcaudan/scrub-telemetry-stack branch May 18, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants