Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗✨ [RUMF-1210] add a trackFrustrations initialization parameter #1524

Merged

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented May 10, 2022

Motivation

Allow to opt-in to frustrations tracking. This change is still behind the frustration-signals experimental feature flag.

Changes

Introduce the trackFrustrations initialization parameter, and use it in trackClickAction.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/add-frustration-signals-initialization-parameter branch from 860c6df to 8ff7c9d Compare May 10, 2022 16:40
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #1524 (1b70435) into main (6cdb9fc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1524      +/-   ##
==========================================
+ Coverage   90.36%   90.38%   +0.02%     
==========================================
  Files         115      115              
  Lines        4442     4443       +1     
  Branches      992      994       +2     
==========================================
+ Hits         4014     4016       +2     
+ Misses        428      427       -1     
Impacted Files Coverage Δ
packages/rum-core/src/domain/configuration.ts 95.83% <100.00%> (+0.37%) ⬆️
...in/rumEventsCollection/action/trackClickActions.ts 96.87% <100.00%> (-0.04%) ⬇️
packages/core/src/tools/timeUtils.ts 100.00% <0.00%> (+2.85%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/add-frustration-signals-initialization-parameter branch from 8ff7c9d to 1b70435 Compare May 10, 2022 16:45
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review May 10, 2022 16:46
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner May 10, 2022 16:46
@BenoitZugmeyer BenoitZugmeyer merged commit 130af6a into main May 11, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/add-frustration-signals-initialization-parameter branch May 11, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants