Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ [RUMF-1182] add telemetry sample rate #1510

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 21, 2022

Motivation

Add a sample rate to control which percentage of pages can send telemetry events.

Changes

  • New init option telemetrySampleRate?: number
  • default value 20, like in the volume projection, could be tweaked when starting to enable customers

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan force-pushed the bcaudan/add-telemetry-sample-rate branch from 02f65c4 to 97c6910 Compare April 21, 2022 09:40
@bcaudan bcaudan marked this pull request as ready for review April 21, 2022 09:41
@bcaudan bcaudan requested a review from a team as a code owner April 21, 2022 09:41
@codecov-commenter
Copy link

Codecov Report

Merging #1510 (bc61cda) into main (bac8452) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
+ Coverage   89.87%   89.91%   +0.03%     
==========================================
  Files         111      111              
  Lines        4316     4322       +6     
  Branches      959      961       +2     
==========================================
+ Hits         3879     3886       +7     
+ Misses        437      436       -1     
Impacted Files Coverage Δ
...ges/core/src/domain/configuration/configuration.ts 100.00% <100.00%> (ø)
...rc/domain/internalMonitoring/internalMonitoring.ts 98.55% <100.00%> (+0.04%) ⬆️
...sCollection/networkError/networkErrorCollection.ts 92.04% <0.00%> (+1.13%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bcaudan bcaudan merged commit bb0a578 into main Apr 21, 2022
@bcaudan bcaudan deleted the bcaudan/add-telemetry-sample-rate branch April 21, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants