Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-1237] The event bridge allowed hosts should also match subdomains #1499

Merged
merged 4 commits into from
Apr 15, 2022

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Apr 13, 2022

Motivation

When a bridge is injected by mobile with AllowedWebViewHosts
The browser SDK should send data to the bridge if on domains and subdomains that match AllowedWebViewHosts

Changes

Update canUseEventBridge

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner April 13, 2022 13:18
@amortemousque amortemousque changed the title ✨ [RUMF-1237] The event bridge should be detected on subdomains ✨ [RUMF-1237] The event bridge allowed hosts should also match subdomains Apr 13, 2022
@amortemousque amortemousque force-pushed the aymeric/bridge-handles-host-checking-subdomain branch from d6a5470 to 658e355 Compare April 13, 2022 13:23
@amortemousque amortemousque force-pushed the aymeric/bridge-handles-host-checking-subdomain branch from 658e355 to a8d22c1 Compare April 13, 2022 13:24
@amortemousque amortemousque force-pushed the aymeric/bridge-handles-host-checking-subdomain branch from 44a3a36 to 73ccf32 Compare April 14, 2022 12:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #1499 (7c81031) into main (d2c96ea) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
- Coverage   89.90%   89.89%   -0.02%     
==========================================
  Files         111      111              
  Lines        4321     4326       +5     
  Branches      962      964       +2     
==========================================
+ Hits         3885     3889       +4     
- Misses        436      437       +1     
Impacted Files Coverage Δ
packages/core/src/transport/eventBridge.ts 100.00% <100.00%> (ø)
...sCollection/networkError/networkErrorCollection.ts 91.11% <0.00%> (-1.12%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@amortemousque amortemousque force-pushed the aymeric/bridge-handles-host-checking-subdomain branch from 356c800 to 238cf95 Compare April 14, 2022 18:53
@amortemousque amortemousque force-pushed the aymeric/bridge-handles-host-checking-subdomain branch from 238cf95 to 7c81031 Compare April 14, 2022 18:56
@amortemousque amortemousque merged commit 59693a2 into main Apr 15, 2022
@amortemousque amortemousque deleted the aymeric/bridge-handles-host-checking-subdomain branch April 15, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants