-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUMF-1237] The event bridge allowed hosts should also match subdomains #1499
Merged
amortemousque
merged 4 commits into
main
from
aymeric/bridge-handles-host-checking-subdomain
Apr 15, 2022
Merged
✨ [RUMF-1237] The event bridge allowed hosts should also match subdomains #1499
amortemousque
merged 4 commits into
main
from
aymeric/bridge-handles-host-checking-subdomain
Apr 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
changed the title
✨ [RUMF-1237] The event bridge should be detected on subdomains
✨ [RUMF-1237] The event bridge allowed hosts should also match subdomains
Apr 13, 2022
amortemousque
force-pushed
the
aymeric/bridge-handles-host-checking-subdomain
branch
from
April 13, 2022 13:23
d6a5470
to
658e355
Compare
amortemousque
force-pushed
the
aymeric/bridge-handles-host-checking-subdomain
branch
from
April 13, 2022 13:24
658e355
to
a8d22c1
Compare
bcaudan
reviewed
Apr 14, 2022
amortemousque
force-pushed
the
aymeric/bridge-handles-host-checking-subdomain
branch
from
April 14, 2022 12:44
44a3a36
to
73ccf32
Compare
Codecov Report
@@ Coverage Diff @@
## main #1499 +/- ##
==========================================
- Coverage 89.90% 89.89% -0.02%
==========================================
Files 111 111
Lines 4321 4326 +5
Branches 962 964 +2
==========================================
+ Hits 3885 3889 +4
- Misses 436 437 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
amortemousque
force-pushed
the
aymeric/bridge-handles-host-checking-subdomain
branch
from
April 14, 2022 18:53
356c800
to
238cf95
Compare
amortemousque
force-pushed
the
aymeric/bridge-handles-host-checking-subdomain
branch
from
April 14, 2022 18:56
238cf95
to
7c81031
Compare
bcaudan
reviewed
Apr 15, 2022
bcaudan
approved these changes
Apr 15, 2022
amortemousque
deleted the
aymeric/bridge-handles-host-checking-subdomain
branch
April 15, 2022 09:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a bridge is injected by mobile with
AllowedWebViewHosts
The browser SDK should send data to the bridge if on domains and subdomains that match AllowedWebViewHosts
Changes
Update canUseEventBridge
Testing
I have gone over the contributing documentation.