⚗✨ [RUMF-1209] introduce "dead" and "error" frustration types

packages/core/src/tools/utils.ts

@@ -589,10 +589,14 @@ export function requestIdleCallback(callback: () => void, opts?: { timeout?: num
   return () => window.cancelAnimationFrame(id)
 }
 
+export function setToArray<T>(set: Set<T>): T[] {
+  const array: T[] = []
+  set.forEach((item) => array.push(item))
+  return array
+}
+
 export function removeDuplicates<T>(array: T[]) {
-  const deduplicated: T[] = []
   const set = new Set<T>()
   array.forEach((item) => set.add(item))
-  set.forEach((item) => deduplicated.push(item))
-  return deduplicated
+  return setToArray(set)
 }

packages/rum-core/src/domain/lifeCycle.ts

@@ -4,7 +4,7 @@ import type { RumEventDomainContext } from '../domainContext.types'
 import type { CommonContext, RawRumEvent } from '../rawRumEvent.types'
 import type { RumEvent } from '../rumEvent.types'
 import type { RequestCompleteEvent, RequestStartEvent } from './requestCollection'
-import type { AutoAction } from './rumEventsCollection/action/trackActions'
+import type { AutoAction } from './rumEventsCollection/action/actionCollection'
 import type { ViewEvent, ViewCreatedEvent, ViewEndedEvent } from './rumEventsCollection/view/trackViews'
 
 export const enum LifeCycleEventType {

packages/rum-core/src/domain/rumEventsCollection/action/actionCollection.spec.ts

@@ -32,6 +32,7 @@ describe('actionCollection', () => {
         longTaskCount: 10,
         resourceCount: 10,
       },
+      frustrationTypes: [],
       duration: 100 as Duration,
       id: 'aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee',
       name: 'foo',
@@ -48,6 +49,7 @@ describe('actionCollection', () => {
         },
         id: 'aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee',
         loading_time: (100 * 1e6) as ServerDuration,
+        frustration_type: [],
         long_task: {
           count: 10,
         },

packages/rum-core/src/domain/rumEventsCollection/action/actionCollection.ts

@@ -1,4 +1,4 @@
-import type { Observable } from '@datadog/browser-core'
+import type { ClocksState, Context, Observable } from '@datadog/browser-core'
 import { noop, assign, combine, toServerDuration, generateUUID } from '@datadog/browser-core'
 
 import type { CommonContext, RawRumActionEvent } from '../../../rawRumEvent.types'
@@ -7,11 +7,20 @@ import type { LifeCycle, RawRumEventCollectedData } from '../../lifeCycle'
 import { LifeCycleEventType } from '../../lifeCycle'
 import type { ForegroundContexts } from '../../foregroundContexts'
 import type { RumConfiguration } from '../../configuration'
-import type { ActionContexts, AutoAction, CustomAction } from './trackActions'
-import { trackActions } from './trackActions'
+import type { ActionContexts, ClickAction } from './trackClickActions'
+import { trackClickActions } from './trackClickActions'
 
 export type { ActionContexts }
 
+export interface CustomAction {
+  type: ActionType.CUSTOM
+  name: string
+  startClocks: ClocksState
+  context?: Context
+}
+
+export type AutoAction = ClickAction
+
 export function startActionCollection(
   lifeCycle: LifeCycle,
   domMutationObservable: Observable<void>,
@@ -24,7 +33,7 @@ export function startActionCollection(
 
   let actionContexts: ActionContexts = { findActionId: noop as () => undefined }
   if (configuration.trackInteractions) {
-    actionContexts = trackActions(lifeCycle, domMutationObservable, configuration).actionContexts
+    actionContexts = trackClickActions(lifeCycle, domMutationObservable, configuration).actionContexts
   }
 
   return {
@@ -50,11 +59,12 @@ function processAction(
   const autoActionProperties = isAutoAction(action)
     ? {
         action: {
+          id: action.id,
+          loading_time: toServerDuration(action.duration),
+          frustration_type: action.frustrationTypes,
           error: {
             count: action.counts.errorCount,
           },
-          id: action.id,
-          loading_time: toServerDuration(action.duration),
           long_task: {
             count: action.counts.longTaskCount,
           },