Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1203] fix stopSessionReplayRecording instrumentation cleanup #1442

Merged
merged 5 commits into from
Mar 23, 2022

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

As observed in #1397 , we badly instrument a few native methods in the recorder:

  • cssStyleSheet.insertRule() and cssStyleSheet.deleteRule()
  • some form input .value property setters

This causes unexpected behavior when calling stopSessionReplayRecording() after another library instrumented those.

Changes

  • Use instrumentMethod on CssStyleSheet methods
  • Implement and use instrumentSetter on input property setters

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested review from a team as code owners March 22, 2022 15:28
@BenoitZugmeyer BenoitZugmeyer merged commit 69a3596 into main Mar 23, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/proper-recorder-stop-uninstrument branch March 23, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants