🐛 [RUMF-1203] fix stopSessionReplayRecording
instrumentation cleanup
#1442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As observed in #1397 , we badly instrument a few native methods in the recorder:
cssStyleSheet.insertRule()
andcssStyleSheet.deleteRule()
.value
property settersThis causes unexpected behavior when calling
stopSessionReplayRecording()
after another library instrumented those.Changes
instrumentMethod
onCssStyleSheet
methodsinstrumentSetter
on input property settersTesting
I have gone over the contributing documentation.