-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ [RUMF-1181] preliminary refactorings for telemetry events collection #1371
Conversation
@@ -95,6 +101,22 @@ export function startRum( | |||
} | |||
} | |||
|
|||
function startRumInternalMonitoring(configuration: RumConfiguration) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: This piece of code is now duplicated in both Logs and RUM. The goal is to be able to modify the RUM version to integrate it with LifeCycle in the follow-up PR, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly, it the exact same thing for now but it will diverge to handle telemetry events
Codecov Report
@@ Coverage Diff @@
## main #1371 +/- ##
==========================================
- Coverage 90.95% 89.95% -1.00%
==========================================
Files 103 102 -1
Lines 4188 4182 -6
Branches 934 934
==========================================
- Hits 3809 3762 -47
- Misses 379 420 +41
Continue to review full report at Codecov.
|
Motivation
Various refactoring mentioned in #1351 to ease the future collection of telemetry events
Changes
Testing
I have gone over the contributing documentation.