-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ [RUMF-1171] prefer const enums #1364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
changed the title
Benoit/prefer const enums
⚡️ [RUMF-1171] prefer const enums everywhere
Feb 28, 2022
BenoitZugmeyer
changed the title
⚡️ [RUMF-1171] prefer const enums everywhere
⚡️ [RUMF-1171] prefer const enums
Feb 28, 2022
BenoitZugmeyer
force-pushed
the
benoit/prefer-const-enums
branch
from
February 28, 2022 15:48
44052fb
to
c15b6ec
Compare
After the previous commit replacing the `IncrementalSource` enum, typechecking is failing because we are using types coming from both `src` (via the `@datadog/browser-rum/test/utils` import) and `cjs` (other imports). I'm not sure why it fails now.
BenoitZugmeyer
force-pushed
the
benoit/prefer-const-enums
branch
from
February 28, 2022 16:01
c15b6ec
to
714894a
Compare
bcaudan
approved these changes
Mar 1, 2022
Codecov Report
@@ Coverage Diff @@
## main #1364 +/- ##
==========================================
- Coverage 91.11% 90.95% -0.17%
==========================================
Files 104 103 -1
Lines 4267 4189 -78
Branches 948 934 -14
==========================================
- Hits 3888 3810 -78
Misses 379 379
Continue to review full report at Codecov.
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Minified size in bytes:
Changes
disallowEnumExports
rule because I noticed that some enums were still exported, and convert theIncrementalSource
enum to a plain objectTesting
I have gone over the contributing documentation.