Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUMF-1103] Remove event bridge FF #1333

Merged
merged 5 commits into from
Feb 16, 2022
Merged

Conversation

amortemousque
Copy link
Collaborator

Motivation

Now that the event bridge implementation is stable, remove the feature flag

Changes

Remove event-bridge FF

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested review from a team as code owners February 11, 2022 13:10
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #1333 (54cd172) into main (3ed427b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1333      +/-   ##
==========================================
+ Coverage   91.03%   91.09%   +0.06%     
==========================================
  Files         106      106              
  Lines        4281     4279       -2     
  Branches      953      951       -2     
==========================================
+ Hits         3897     3898       +1     
+ Misses        384      381       -3     
Impacted Files Coverage Δ
packages/core/src/transport/eventBridge.ts 100.00% <100.00%> (ø)
packages/rum-core/src/boot/rumPublicApi.ts 94.79% <100.00%> (ø)
packages/core/src/tools/utils.ts 87.83% <0.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed427b...54cd172. Read the comment docs.

@amortemousque amortemousque merged commit b6ff83f into main Feb 16, 2022
@amortemousque amortemousque deleted the aymeric/remove-event-bridge-ff branch February 16, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants