Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ [RUMF-1030] Decrease BoundedBuffer limitation to 500 #1242

Merged
merged 5 commits into from
Jan 5, 2022

Conversation

amortemousque
Copy link
Contributor

Motivation

The BoundedBuffer is used to buffer api calls before the SDK initialisation. It stores views, actions, and errors and has a limit of 10000 api calls. In case of big user defined contexts or if the init() is never called, it can have a significant impact.
This PR decrease the limit from 10000 to 500 buffered api calls to lower our memory impact.

Changes

Decrease bounded buffer limitation to 500

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner January 4, 2022 15:39
@amortemousque amortemousque changed the title ⚡️ Decrease BoundedBuffer limitation to 500 ⚡️ [RUMF-1030] Decrease BoundedBuffer limitation to 500 Jan 4, 2022
@amortemousque amortemousque force-pushed the aymeric/decrease-bounded-buffer-limitation branch from 9356fe4 to d386406 Compare January 4, 2022 15:43
@codecov-commenter
Copy link

Codecov Report

Merging #1242 (9356fe4) into main (7908b7f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9356fe4 differs from pull request most recent head d386406. Consider uploading reports for the commit d386406 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1242   +/-   ##
=======================================
  Coverage   89.04%   89.04%           
=======================================
  Files         103      103           
  Lines        4310     4310           
  Branches      985      985           
=======================================
  Hits         3838     3838           
  Misses        472      472           
Impacted Files Coverage Δ
packages/core/src/tools/boundedBuffer.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7908b7f...d386406. Read the comment docs.

@amortemousque amortemousque merged commit 61099bd into main Jan 5, 2022
@amortemousque amortemousque deleted the aymeric/decrease-bounded-buffer-limitation branch January 5, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants