Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 [RUMF-1105]Add module convention to contributing #1240

Merged

Conversation

amortemousque
Copy link
Collaborator

Motivation

Add the modules usage convention into the contribution guidelines.

Changes

guidelines

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner January 3, 2022 17:03
Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amortemousque amortemousque merged commit 1212ecb into main Jan 5, 2022
@amortemousque amortemousque deleted the aymeric/modules-usages-convention-in-contributing branch January 5, 2022 15:40
@amortemousque amortemousque changed the title 📝 Add module convention to contributing 📝 [RUMF-1105]Add module convention to contributing Jan 5, 2022
BenoitZugmeyer added a commit that referenced this pull request Jan 6, 2022
…g-02

 pm_trace_id: 6532791
 feature_branch_pipeline_id: 6532791
 source: to-staging

* commit '870a7006ae3216378cfd17b4ff08679cf71206d0':
  🐛 remove child with action-names innerText instead of replacing them
  📝 Add module convention to contributing (#1240)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants