Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix proxy url intake detection #1223

Merged
merged 3 commits into from
Dec 20, 2021

Conversation

amortemousque
Copy link
Collaborator

Motivation

With the current proxyUrl implementation, if a user set the same url for his proxy and his backend, we con't collect backend requests as resources.

Example:

init({proxyUrl: 'https://www.proxy.com'...})
fetch('https://www.proxy.com/foo') // no resource collected

Changes

Update buildIntakeUrl logic

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner December 16, 2021 15:26
@amortemousque amortemousque force-pushed the aymeric/fix-proxy-url-intake-detection branch from 066b461 to 9e29555 Compare December 16, 2021 15:31
@amortemousque amortemousque force-pushed the aymeric/fix-proxy-url-intake-detection branch from 8a78484 to 4d6b885 Compare December 16, 2021 17:32
@codecov-commenter
Copy link

Codecov Report

Merging #1223 (c10c20d) into main (fea6134) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1223   +/-   ##
=======================================
  Coverage   89.00%   89.01%           
=======================================
  Files         101      101           
  Lines        4321     4324    +3     
  Branches      986      988    +2     
=======================================
+ Hits         3846     3849    +3     
  Misses        475      475           
Impacted Files Coverage Δ
...s/core/src/domain/configuration/endpointBuilder.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea6134...c10c20d. Read the comment docs.

@amortemousque amortemousque merged commit 433202e into main Dec 20, 2021
@amortemousque amortemousque deleted the aymeric/fix-proxy-url-intake-detection branch December 20, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants