🔥 [RUMF-1089] Cleanup legacy intake URLs #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
changed the title
amortemousque
force-pushed
the
aymeric/clean-legacy-intake-URLs
branch
from
6e6a10b to
62c9430
Compare
Codecov Report
@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
- Coverage 89.07% 89.04% -0.04%
==========================================
Files 100 100
Lines 4304 4289 -15
Branches 980 975 -5
==========================================
- Hits 3834 3819 -15
Misses 470 470
Continue to review full report at Codecov.
|
BenoitZugmeyer
approved these changes
Dec 13, 2021
bcaudan
reviewed
Dec 13, 2021
packages/core/src/domain/configuration/transportConfiguration.spec.ts
Outdated
Show resolved
Hide resolved
packages/core/src/domain/configuration/transportConfiguration.spec.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Dec 13, 2021
Comment on lines
+7
to
+10
| logs: 'logs', | ||
| rum: 'rum', | ||
| sessionReplay: 'session-replay', | ||
| } as const |
There was a problem hiding this comment.
should we start to prepare the list of breaking changes with every v4 PR? something like what we did for v3 https://github.com/DataDog/browser-sdk/blob/main/CHANGELOG.md#v300
There was a problem hiding this comment.
Sure, I'll do it in a following PR
amortemousque
force-pushed
the
aymeric/clean-legacy-intake-URLs
branch
from
7fe07f6 to
19f27c2
Compare
bcaudan
approved these changes
Dec 14, 2021
BenoitZugmeyer
added a commit
that referenced
this pull request
Dec 15, 2021
…ng-51 pm_trace_id: 6351007 feature_branch_pipeline_id: 6351007 source: to-staging * commit '87ee85682347e9d7a8efc46f4b8d7388af82f518': ✅ use valid tag values in tests 👌 simplify implementation 🔥 [RUMF-1089] Cleanup legacy intake URLs (#1214) ✨ [RUMF-827] sanitize tags ♻️ [RUMF-827] add function to build tags at a higher level
BenoitZugmeyer
added a commit
that referenced
this pull request
Jan 4, 2022
pm_trace_id: 6502873 feature_branch_pipeline_id: 6502873 source: to-staging * commit '65ad0eeefe4f2a22e0665cab456ab6c7e1636b4d': 📝 [RUMF-1130] add migration guide to the CHANGELOG (#1238) v3.11.0 (#1239) 🐛 improve privacy computation on a single node (#1226) 🏷️ [RUMF-1098] move init options into their related interfaces (#1232) 🔥 [RUMF-1093] deprecated proxyhost option (#1227) 🐛 [RUMF-1124] Use the programmatic action attribute instead of innertext (#1200) 🔥 [RUMF-1094] remove deprecated privacy attributes (#1224) ♻️ [RUMF-1092] use a WeakMap to store XHR context (#1222) ✅ [RUMF-1090] update minimal version to 3.8.2 (#1219) ✨ [RUMF-827] sanitize tags (#1218) 🔥 [RUMF-1089] Cleanup legacy intake URLs (#1214)
BenoitZugmeyer
added a commit
that referenced
this pull request
Jan 4, 2022
* 🔥 [RUMF-1089] Cleanup legacy intake URLs (#1214) * 🔥 Cleanup legacy intake URLs * Use parametrized test * ✨ [RUMF-827] sanitize tags (#1218) * ♻️ [RUMF-827] add function to build tags at a higher level * ✨ [RUMF-827] sanitize tags * 👌 simplify implementation * Single warning message * Keep sanitization to make sure we can't forge multiple tags from a single value * Removed the "ending semicolon" restriction since it only applies if there is no other semicolon in the whole tag (ex: "env:bar:" and "env::" are valid, but "env:" is not). Here, we are sure there is a semicolon, since we add one ourselves. * ✅ use valid tag values in tests * ✅ [RUMF-1090] update minimal version to 3.8.2 (#1219) * ✅ [RUMF-1090] update minimal version to 3.8.2 * 👌 update mentions of TS 3.0 * 🔥 remove typings utilities now available in TS * ♻️ [RUMF-1092] use a WeakMap to store XHR context (#1222) * ♻️ [RUMF-1092] use a WeakMap to store XHR context * smaller weakmap typings Co-authored-by: Aymeric <[email protected]> Co-authored-by: Aymeric <[email protected]> * 🔥 [RUMF-1094] remove deprecated privacy attributes (#1224) * 🔥 [RUMF-1094] remove deprecated attributes * ✅ revamp privacy.spec tests To have a better vision on what's being tested by `privacy.spec`, some cleanup was necessary. I took the opportunity to remove some deprecated variables to improve things here. * `getNodeSelfPrivacyLevel`: consolidate tests with more test cases and highlight current modes priority * `getNodePrivacyLevel`: remove tests cases when they are already handled by `getNodeSelfPrivacyLevel` and consolidate tests on fallback value and inheritance * `serializeDocumentNode`: move those tests to `serialize.spec` since we don't use privacy functions here As well as a few cosmetic changes. * 🐛 [RUMF-1124] Use the programmatic action attribute instead of innertext (#1200) * Use the programmatic action attribute instead of innertext for fetching the textual content Use the programmatic action attribute instead of innertext for fetching the textual content * Addressing the review comments * also consider programmatic action names from user defined attribute * 🐛 fix compatibility with IE11 * 👌 move tests into a more appropriate `describe` Co-authored-by: Benoît Zugmeyer <[email protected]> * 🔥 [RUMF-1093] deprecated proxyhost option (#1227) * 🔥 Remove deprecated proxyhost option * Update performance project * ♻️ Simplidy endpointBuilder Co-authored-by: Benoît Zugmeyer <[email protected]> * 🏷️ [RUMF-1098] move init options into their related interfaces (#1232) * 🏷️ [RUMF-1098] move init options into their related interfaces Also, reorder/group init options * 👌 use ReadonlyArray for allowedTracingOrigins * 👌 make beforeSend typing clearer in core * 🐛 improve privacy computation on a single node (#1226) This commit make sure class names and attributes are treated equally, and that the most restrictive privacy level takes precedence over the other. * 📝 [RUMF-1130] add migration guide to the CHANGELOG (#1238) * 📝 [RUMF-1130] add migration guide to the CHANGELOG * 👌 review changes * Update CHANGELOG.md Co-authored-by: Bastien Caudan <[email protected]> Co-authored-by: Bastien Caudan <[email protected]> * 👌 fix small typo in CHANGELOG Co-authored-by: Aymeric <[email protected]> Co-authored-by: MaheshGit233 <[email protected]> Co-authored-by: Bastien Caudan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To promote usages of intakes v2, we want to remove support for “classic domains” and intakes v1, to keep only “alternate domains” and intakes v2. This will greatly reduce the complexity of computing the transport configuration
Changes
Testing
I have gone over the contributing documentation.