:✨⚗ [RUMF-1047] implement a RUM synthetics entry point #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit has nothing much to do with the PR, but was introduced in a previous PR and still relevant.
BenoitZugmeyer
changed the title
4 tasks
bcaudan
approved these changes
Nov 30, 2021
Codecov Report
@@ Coverage Diff @@
## main #1188 +/- ##
==========================================
- Coverage 88.98% 88.90% -0.08%
==========================================
Files 100 100
Lines 4285 4283 -2
Branches 969 970 +1
==========================================
- Hits 3813 3808 -5
- Misses 472 475 +3
Continue to review full report at Codecov.
|
Fix the rum-slim package changing its directory structure because it has no other module than entries/main: https://github.com/Microsoft/TypeScript/wiki/FAQ#why-does---outdir-moves-output-after-adding-a-new-file While this option is not required for other packages, it is still a good failsafe to make sure the directory structure changes when moving modules around.
amortemousque
approved these changes
Dec 3, 2021
bcaudan
approved these changes
Dec 3, 2021
bcaudan
pushed a commit
that referenced
this pull request
Dec 7, 2021
* ✨ create a new entry point for synthetics * 👷📝 validate and document existing build modes This commit has nothing much to do with the PR, but was introduced in a previous PR and still relevant. * 📝 document the test to add some context, and fix a unit test title * 👌 move RUM entry points * 👌 move Logs entry point * 👌 move RUM-slim entry point * add tsconfig "rootDir" Fix the rum-slim package changing its directory structure because it has no other module than entries/main: https://github.com/Microsoft/TypeScript/wiki/FAQ#why-does---outdir-moves-output-after-adding-a-new-file While this option is not required for other packages, it is still a good failsafe to make sure the directory structure changes when moving modules around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allows the Synthetics worker to inject RUM instances into test runs.
This PR superseds #1179
Changes
Provide a new entry point to be consumed by the Synthetics worker. As per RFC, this entry point won't define any global API, and won't ignore the
init()call if the Synthetics worker is set to automatically inject RUM instance (as this is the instance that will be injected).Testing
I have gone over the contributing documentation.