✨ [RUMF-1084] ignore init if a RUM instance is or will be injected by synthetics #1170
Conversation
| @@ -0,0 +1,30 @@ | |||
| import { getCookie } from '@datadog/browser-core' | |||
There was a problem hiding this comment.
tools/syntheticsContext.ts, should it be consider as a tool?
There was a problem hiding this comment.
Would you rather put it in domain? I thought it wasn't directly related to how RUM works, but happy to move it elsewhere.
There was a problem hiding this comment.
Why not to have tools, but I would also think of moving other components like ContextHistory which also looks like tools.
There was a problem hiding this comment.
IMO
- syntheticsContext -> domain
- contextHistory -> tools
To avoid any side effect like warning message, let's bail out earlier.
Codecov Report
@@ Coverage Diff @@
## main #1170 +/- ##
==========================================
+ Coverage 88.69% 88.71% +0.01%
==========================================
Files 97 98 +1
Lines 4264 4270 +6
Branches 962 964 +2
==========================================
+ Hits 3782 3788 +6
Misses 482 482
Continue to review full report at Codecov.
|
Motivation
Allows the Synthetics worker to prevent any RUM SDK initialisation if it plans to inject a RUM instance itself.
Changes
init()call based on values (global variables/cookies) provided by the Synthetics workerTesting
I have gone over the contributing documentation.