-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUMF-1068] Forward browser_sdk_version to mobile #1162
Conversation
4e1319f
to
0345f87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me
Codecov Report
@@ Coverage Diff @@
## main #1162 +/- ##
=======================================
Coverage 88.71% 88.71%
=======================================
Files 98 98
Lines 4270 4271 +1
Branches 964 965 +1
=======================================
+ Hits 3788 3789 +1
Misses 482 482
Continue to review full report at Codecov.
|
Motivation
The mobile SDKs (Android and iOS) want to track events that happen inside a webView using the browser SDK. The proposed way to do that is to inject a JS bridge interface that the browser SDK will call instead of sending the events to the intake.
To easily monitor browser sdk event sent though mobile, we need to keep the browser SDK version tag.
Because it is not easy for the mobile to keep browser tag, this first version send it as
_dd
attribute.Changes
Add
browser_sdk_version
in_dd
Testing
I have gone over the contributing documentation.