Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUMF-1068] Forward browser_sdk_version to mobile #1162

Merged
merged 8 commits into from
Dec 6, 2021

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Nov 12, 2021

Motivation

The mobile SDKs (Android and iOS) want to track events that happen inside a webView using the browser SDK. The proposed way to do that is to inject a JS bridge interface that the browser SDK will call instead of sending the events to the intake.

To easily monitor browser sdk event sent though mobile, we need to keep the browser SDK version tag.
Because it is not easy for the mobile to keep browser tag, this first version send it as _dd attribute.

Changes

Add browser_sdk_version in _dd

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner November 12, 2021 09:19
@amortemousque amortemousque force-pushed the aymeric/forward-tags-to-bridge branch from 4e1319f to 0345f87 Compare November 12, 2021 12:20
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

packages/rum-core/test/specHelper.ts Outdated Show resolved Hide resolved
packages/rum-core/src/domain/assembly.ts Outdated Show resolved Hide resolved
packages/core/src/domain/configuration/configuration.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #1162 (1cba1d4) into main (a7e7de1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1162   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files          98       98           
  Lines        4270     4271    +1     
  Branches      964      965    +1     
=======================================
+ Hits         3788     3789    +1     
  Misses        482      482           
Impacted Files Coverage Δ
packages/rum-core/src/rawRumEvent.types.ts 100.00% <ø> (ø)
packages/rum-core/src/domain/assembly.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e7de1...1cba1d4. Read the comment docs.

@amortemousque amortemousque merged commit edad30f into main Dec 6, 2021
@amortemousque amortemousque deleted the aymeric/forward-tags-to-bridge branch December 6, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants