-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Discard views and actions with negative loading time #1122
Merged
amortemousque
merged 6 commits into
main
from
aymeric/discard-negtive-loading-time-events
Oct 12, 2021
Merged
🐛 Discard views and actions with negative loading time #1122
amortemousque
merged 6 commits into
main
from
aymeric/discard-negtive-loading-time-events
Oct 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
force-pushed
the
aymeric/discard-negtive-loading-time-events
branch
from
October 7, 2021 13:04
a9dfc15
to
f0feee9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
- Coverage 88.97% 88.97% -0.01%
==========================================
Files 92 92
Lines 4217 4216 -1
Branches 970 970
==========================================
- Hits 3752 3751 -1
Misses 465 465
Continue to review full report at Codecov.
|
amortemousque
force-pushed
the
aymeric/discard-negtive-loading-time-events
branch
from
October 7, 2021 13:08
f0feee9
to
b85b74d
Compare
bcaudan
reviewed
Oct 7, 2021
packages/rum-core/src/domain/rumEventsCollection/action/actionCollection.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Oct 11, 2021
packages/rum-core/src/domain/rumEventsCollection/action/trackActions.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/action/trackActions.spec.ts
Outdated
Show resolved
Hide resolved
BenoitZugmeyer
approved these changes
Oct 11, 2021
amortemousque
force-pushed
the
aymeric/discard-negtive-loading-time-events
branch
3 times, most recently
from
October 11, 2021 15:07
eccdd95
to
4548a13
Compare
amortemousque
force-pushed
the
aymeric/discard-negtive-loading-time-events
branch
from
October 11, 2021 15:26
4548a13
to
9b8a359
Compare
bcaudan
reviewed
Oct 11, 2021
packages/rum-core/src/domain/rumEventsCollection/action/trackActions.ts
Outdated
Show resolved
Hide resolved
amortemousque
force-pushed
the
aymeric/discard-negtive-loading-time-events
branch
from
October 12, 2021 09:24
dc9a05e
to
b9db003
Compare
bcaudan
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It happens to have negative loading time on view and actions. It’s really rare around 0.000175% of click actions.
To keep meaningful data, let's discard them.
Changes
Testing
Unit
I have gone over the contributing documentation.