Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Discard views and actions with negative loading time #1122

Merged
merged 6 commits into from
Oct 12, 2021

Conversation

amortemousque
Copy link
Collaborator

Motivation

It happens to have negative loading time on view and actions. It’s really rare around 0.000175% of click actions.
To keep meaningful data, let's discard them.

Changes

  • Discard actions with negative loading time
  • Discard view loading_time value if negative

Testing

Unit


I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner October 7, 2021 13:02
@amortemousque amortemousque force-pushed the aymeric/discard-negtive-loading-time-events branch from a9dfc15 to f0feee9 Compare October 7, 2021 13:04
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #1122 (7159ac3) into main (97affa0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
- Coverage   88.97%   88.97%   -0.01%     
==========================================
  Files          92       92              
  Lines        4217     4216       -1     
  Branches      970      970              
==========================================
- Hits         3752     3751       -1     
  Misses        465      465              
Impacted Files Coverage Δ
.../domain/rumEventsCollection/action/trackActions.ts 97.95% <100.00%> (+1.80%) ⬆️
...omain/rumEventsCollection/view/trackViewMetrics.ts 100.00% <100.00%> (ø)
.../domain/rumEventsCollection/view/viewCollection.ts 100.00% <100.00%> (ø)
packages/rum-core/src/domain/waitIdlePage.ts 98.14% <100.00%> (+0.03%) ⬆️
...e/src/domain/configuration/experimentalFeatures.ts 92.30% <0.00%> (-7.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97affa0...7159ac3. Read the comment docs.

@amortemousque amortemousque force-pushed the aymeric/discard-negtive-loading-time-events branch from f0feee9 to b85b74d Compare October 7, 2021 13:08
@amortemousque amortemousque force-pushed the aymeric/discard-negtive-loading-time-events branch 3 times, most recently from eccdd95 to 4548a13 Compare October 11, 2021 15:07
@amortemousque amortemousque force-pushed the aymeric/discard-negtive-loading-time-events branch from 4548a13 to 9b8a359 Compare October 11, 2021 15:26
@amortemousque amortemousque force-pushed the aymeric/discard-negtive-loading-time-events branch from dc9a05e to b9db003 Compare October 12, 2021 09:24
@amortemousque amortemousque merged commit c6cffa6 into main Oct 12, 2021
@amortemousque amortemousque deleted the aymeric/discard-negtive-loading-time-events branch October 12, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants