Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 Add monitoring on session type change #1075

Merged
merged 5 commits into from
Sep 27, 2021
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Sep 27, 2021

Motivation

cf #1066, #1072

Changes

Add log on unexpected session type change

Testing

locally


I have gone over the contributing documentation.

@bcaudan bcaudan marked this pull request as ready for review September 27, 2021 08:35
@bcaudan bcaudan requested a review from a team as a code owner September 27, 2021 08:35
@bcaudan bcaudan changed the title 🔊 Add monitoring session type change 🔊 Add monitoring on session type change Sep 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2021

Codecov Report

Merging #1075 (9891dfc) into main (6f8a91b) will decrease coverage by 0.06%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1075      +/-   ##
==========================================
- Coverage   89.18%   89.12%   -0.07%     
==========================================
  Files          90       90              
  Lines        4161     4165       +4     
  Branches      950      951       +1     
==========================================
+ Hits         3711     3712       +1     
- Misses        450      453       +3     
Impacted Files Coverage Δ
packages/core/src/domain/sessionManagement.ts 97.67% <85.71%> (-2.33%) ⬇️
packages/core/src/tools/timeUtils.ts 90.90% <0.00%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f8a91b...9891dfc. Read the comment docs.

@bcaudan bcaudan merged commit 427302e into main Sep 27, 2021
@bcaudan bcaudan deleted the bcaudan/monitoring-plan-part3 branch September 27, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants