[RUMF-1028] enable privacy by default #1049
Conversation
| @@ -52,6 +52,9 @@ describe('startRecording', () => { | |||
| }, | |||
| }) | |||
| .withSession(session) | |||
| .withConfiguration({ | |||
| initialPrivacyLevel: InitialPrivacyLevel.ALLOW, | |||
There was a problem hiding this comment.
With the default privacy level (mask forms only) data compression is too efficient (🎉), so segments are not reaching the compressed size limit.
Codecov Report
@@ Coverage Diff @@
## main #1049 +/- ##
==========================================
- Coverage 89.01% 88.98% -0.03%
==========================================
Files 87 87
Lines 4134 4132 -2
Branches 950 948 -2
==========================================
- Hits 3680 3677 -3
- Misses 454 455 +1
Continue to review full report at Codecov.
|
|
@acorretti To be clear here, regarding the public facing "privacy" API spec, you mean the following changes? Exhaustively (and redundantly) the changes are:
|
|
That'd be it @jagracey 👍 |
|
LGTM |
|
This is missing updated docs for https://docs.datadoghq.com/real_user_monitoring/browser |
|
@eddiemonge are you looking for session replay privacy options doc? |
|
@bcaudan its nice that its documented there, but it should also be part of the configuration initialization docs. https://docs.datadoghq.com/real_user_monitoring/browser/#configuration |
|
Indeed, it should land soon, cf #1152 |
Motivation
Let our users specify a initial privacy level for session replay. This should default to
mask-forms-only.Changes
Enable privacy by default, in particular the
initialPrivacyLeveloption, and change its default.Testing
CI + tested on org2
I have gone over the contributing documentation.