[RUMF-1020] enable intake v2 #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests have been reworked a bit, because they were not duplicated with and without the flag: those with the `support-intake-v2` flag enabled are still relevant.
acorretti
approved these changes
Sep 14, 2021
Codecov Report
@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
- Coverage 89.12% 89.11% -0.01%
==========================================
Files 88 88
Lines 4138 4135 -3
Branches 949 947 -2
==========================================
- Hits 3688 3685 -3
Misses 450 450
Continue to review full report at Codecov.
|
BenoitZugmeyer
force-pushed
the
benoit/enable-intake-v2
branch
from
63a4cd1 to
dedd318
Compare
bcaudan
reviewed
Sep 14, 2021
…ntakeDomains`" This reverts commit dedd318.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enable intake v2 on all orgs. This will:
intakeApiVersioninit configuration option (default to 1)Changes
Tests have been reworked a bit, because they were not duplicated with and without the flag: those with the
support-intake-v2flag enabled are still relevant.Testing
CI
I have gone over the contributing documentation.