[RUMF-976] add info to monitor failing xhr fallback #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
changed the title
amortemousque
force-pushed
the
aymeric/monitor-failing-xhr-fallback
branch
from
5e4851e to
7108062
Compare
amortemousque
force-pushed
the
aymeric/monitor-failing-xhr-fallback
branch
from
7108062 to
c906de7
Compare
bcaudan
approved these changes
Sep 8, 2021
| @@ -52,7 +52,7 @@ export class HttpRequest { | |||
| request: { | |||
| status: req.status, | |||
| ready_state: req.readyState, | |||
| response_text: req.responseText.slice(0, 64), | |||
| response_text: req.responseText.slice(0, 256), | |||
There was a problem hiding this comment.
are we confident that it will be enough?
There was a problem hiding this comment.
Hum, I made it 512 to be sure. FUI the message currently cuts at "... error:", so all the rest will be the error message.
Codecov Report
@@ Coverage Diff @@
## main #1035 +/- ##
=======================================
Coverage 88.93% 88.93%
=======================================
Files 88 88
Lines 4166 4168 +2
Branches 958 959 +1
=======================================
+ Hits 3705 3707 +2
Misses 461 461
Continue to review full report at Codecov.
|
BenoitZugmeyer
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The browser SDK uses sendBeacon() when available and the size < (16KB for rum, 60ko for replay). If not, it falls back to XMLHttpRequest. In some cases the XHR requests fail. This PR adds some information in the internal monitoring to better understand the reasons of this issue.
Changes
Testing
Unit, Locally
I have gone over the contributing documentation.