Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1005] Fix dd-request-id endpoint query param #1018

Merged

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Aug 30, 2021

Motivation

Fix intake v2 dd-request-id to be unique per request

Changes

Add dd-request-id to HttpRequest

Testing

Locally, Unit

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner August 30, 2021 15:23
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #1018 (7cff6d0) into main (589ade3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
+ Coverage   88.98%   89.01%   +0.02%     
==========================================
  Files          88       88              
  Lines        4132     4134       +2     
  Branches      949      949              
==========================================
+ Hits         3677     3680       +3     
+ Misses        455      454       -1     
Impacted Files Coverage Δ
...s/core/src/domain/configuration/endpointBuilder.ts 100.00% <ø> (ø)
packages/core/src/transport/httpRequest.ts 97.05% <100.00%> (+0.18%) ⬆️
packages/core/src/tools/timeUtils.ts 93.93% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589ade3...7cff6d0. Read the comment docs.

@amortemousque amortemousque force-pushed the aymeric/make-intake-request-id-unique-per-request branch from ce160d3 to 0c0fffe Compare August 30, 2021 15:26
@amortemousque amortemousque merged commit 5d97167 into main Sep 6, 2021
@bcaudan bcaudan deleted the aymeric/make-intake-request-id-unique-per-request branch September 13, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants