Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-996] set synthetics ids on RUM events #1007

Merged
merged 3 commits into from
Aug 20, 2021

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

Allow linking RUM to Synthetics tests

Changes

Add Synthetics test id and result id to all RUM events based on global variables. In the future, it will also use cookies, but since we don't know yet how they will be defined, let's do only global variables first.

Testing

Manual, Unit


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner August 20, 2021 13:15
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #1007 (90f03b2) into main (fdcb5f9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
+ Coverage   89.04%   89.05%   +0.01%     
==========================================
  Files          86       86              
  Lines        4115     4119       +4     
  Branches      946      946              
==========================================
+ Hits         3664     3668       +4     
  Misses        451      451              
Impacted Files Coverage Δ
packages/rum-core/src/rawRumEvent.types.ts 100.00% <ø> (ø)
packages/rum-core/src/domain/assembly.ts 98.11% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdcb5f9...90f03b2. Read the comment docs.

Copy link
Contributor

@webNeat webNeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@BenoitZugmeyer BenoitZugmeyer merged commit f749889 into main Aug 20, 2021
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/add-synthetics-ids branch August 20, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants