🐛[jsonStringify] do not crash on serialization error (#242)

fixes #236
DataDog · Jan 24, 2020 · e2ead99 · e2ead99
1 parent cab0b40
commit e2ead99
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/core/src/utils.ts b/packages/core/src/utils.ts
@@ -150,8 +150,11 @@ export function jsonStringify(
     }
   }
 
+  let result: string
   try {
-    return JSON.stringify(value, replacer, space)
+    result = JSON.stringify(value, undefined, space)
+  } catch {
+    result = '<error: unable to serialize object>'
   } finally {
     if (originalToJSON[0]) {
       ;(value as ObjectWithToJSON).toJSON = originalToJSON[1]
@@ -160,6 +163,7 @@ export function jsonStringify(
       ;(prototype as ObjectWithToJSON).toJSON = originalProtoToJSON[1]
     }
   }
+  return result
 }
 
 function hasToJSON(value: unknown): value is ObjectWithToJSON {

diff --git a/packages/core/test/utils.spec.ts b/packages/core/test/utils.spec.ts
@@ -242,6 +242,13 @@ describe('utils', () => {
       expect(jsonStringify(1)).toEqual('1')
       expect(jsonStringify(true)).toEqual('true')
     })
+
+    it('should not crash on serialization error', () => {
+      const circularReference: any = { otherData: 123 }
+      ;(circularReference as any).myself = circularReference
+
+      expect(jsonStringify(circularReference)).toEqual('<error: unable to serialize object>')
+    })
   })
 
   it('should perform a draw', () => {