Skip to content

Commit

Permalink
♻️ [devext] move margin to Columns component
Browse files Browse the repository at this point in the history
For the Replay tab, we don't want any margin, so this commit moves the
margin from the base Tabs to the Columns component used by the other
tabs.
  • Loading branch information
BenoitZugmeyer committed May 15, 2023
1 parent d93e0c1 commit d76b25a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
6 changes: 5 additions & 1 deletion developer-extension/src/panel/components/columns.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ import { Grid, Space, Title } from '@mantine/core'
import React from 'react'

export function Columns({ children }: { children: React.ReactNode }) {
return <Grid>{children}</Grid>
return (
<Grid mt="sm" mx="sm">
{children}
</Grid>
)
}

function Column({ children, title }: { children: React.ReactNode; title: string }) {
Expand Down
3 changes: 1 addition & 2 deletions developer-extension/src/panel/components/tabBase.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ export function TabBase({ top, children }: TabBaseProps) {
</Container>
</>
)}
<Container fluid sx={{ flex: 1, overflowY: 'auto', margin: 0 }}>
{!top && <Space h="sm" />}
<Container fluid sx={{ flex: 1, overflowY: 'auto', padding: 0, margin: 0 }}>
{children}
</Container>
</Flex>
Expand Down

0 comments on commit d76b25a

Please sign in to comment.