Skip to content

Commit

Permalink
no need to pass a formatter anymore
Browse files Browse the repository at this point in the history
  • Loading branch information
bcaudan committed Apr 2, 2021
1 parent 8819ec5 commit b020e25
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/core/src/domain/automaticErrorCollection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export function startConsoleTracking(errorObservable: ErrorObservable) {
function buildErrorFromParams(params: unknown[]) {
const firstErrorParam = find(params, (param: unknown): param is Error => param instanceof Error)
return {
message: ['console error:', ...params].map((param) => formatConsoleParameters(formatErrorMessage, param)).join(' '),
message: ['console error:', ...params].map((param) => formatConsoleParameters(param)).join(' '),
stack: firstErrorParam ? toStackTraceString(computeStackTrace(firstErrorParam)) : undefined,
}
}
Expand All @@ -68,12 +68,12 @@ export function stopConsoleTracking() {
console.error = originalConsoleError
}

function formatConsoleParameters(stackTraceFormatter: (stack: StackTrace) => string, param: unknown) {
function formatConsoleParameters(param: unknown) {
if (typeof param === 'string') {
return param
}
if (param instanceof Error) {
return stackTraceFormatter(computeStackTrace(param))
return formatErrorMessage(computeStackTrace(param))
}
return jsonStringify(param, undefined, 2)
}
Expand Down

0 comments on commit b020e25

Please sign in to comment.