⚡️ [RUMF-1043] forbid array spread

DataDog · Feb 17, 2022 · 9f58edd · 9f58edd
1 parent ccddfa0
commit 9f58edd
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 5 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -220,6 +220,10 @@ module.exports = {
             selector: 'ObjectExpression > SpreadElement',
             message: 'Object spread is not authorized. Please use "assign" from the core package utils instead.',
           },
+          {
+            selector: 'ArrayExpression > SpreadElement',
+            message: 'Array spread is not authorized. Please use .concat instead.',
+          },
         ],
       },
     },

diff --git a/eslint-local-rules/disallowSideEffects.js b/eslint-local-rules/disallowSideEffects.js
@@ -173,6 +173,11 @@ function isAllowedCallExpression({ callee }) {
     return true
   }
 
+  // Allow ".concat()"
+  if (callee.type === 'MemberExpression' && callee.property.name === 'concat') {
+    return true
+  }
+
   return false
 }
 

diff --git a/packages/core/src/domain/console/consoleObservable.ts b/packages/core/src/domain/console/consoleObservable.ts
@@ -58,7 +58,10 @@ function createConsoleObservable(api: ConsoleApiName) {
 
 function buildConsoleLog(params: unknown[], api: ConsoleApiName, handlingStack: string): ConsoleLog {
   const log: ConsoleLog = {
-    message: [`console ${api}:`, ...params].map((param) => formatConsoleParameters(param)).join(' '),
+    message: [`console ${api}:` as unknown]
+      .concat(params)
+      .map((param) => formatConsoleParameters(param))
+      .join(' '),
     api,
   }
 

diff --git a/packages/core/src/transport/batch.ts b/packages/core/src/transport/batch.ts
@@ -36,7 +36,7 @@ export class Batch {
 
   flush(reason?: string) {
     if (this.bufferMessageCount !== 0) {
-      const messages = [...this.pushOnlyBuffer, ...objectValues(this.upsertBuffer)]
+      const messages = this.pushOnlyBuffer.concat(objectValues(this.upsertBuffer))
       this.request.send(messages.join('\n'), this.bufferBytesSize, reason)
       this.pushOnlyBuffer = []
       this.upsertBuffer = {}

diff --git a/packages/rum-core/src/domain/assembly.ts b/packages/rum-core/src/domain/assembly.ts
@@ -49,11 +49,10 @@ const VIEW_EVENTS_MODIFIABLE_FIELD_PATHS = [
   'resource.url',
 ]
 
-const OTHER_EVENTS_MODIFIABLE_FIELD_PATHS = [
-  ...VIEW_EVENTS_MODIFIABLE_FIELD_PATHS,
+const OTHER_EVENTS_MODIFIABLE_FIELD_PATHS = VIEW_EVENTS_MODIFIABLE_FIELD_PATHS.concat([
   // User-customizable field
   'context',
-]
+])
 
 type Mutable<T> = { -readonly [P in keyof T]: T[P] }