implement WeakRef types

DataDog · May 15, 2024 · 7b89929 · 7b89929
1 parent 7ed6dbf
commit 7b89929
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/packages/core/src/browser/types.ts b/packages/core/src/browser/types.ts
@@ -39,6 +39,18 @@ export interface VisualViewport extends EventTarget {
   ): void
 }
 
+export interface WeakRef<T extends object> {
+  readonly [Symbol.toStringTag]: 'WeakRef'
+
+  deref(): T | undefined
+}
+
+export interface WeakRefConstructor {
+  readonly prototype: WeakRef<any>
+
+  new <T extends object>(target: T): WeakRef<T>
+}
+
 // Those are native API types that are not official supported by TypeScript yet
 
 export interface CookieStore extends EventTarget {}

diff --git a/packages/rum-core/src/domain/view/viewMetrics/trackCumulativeLayoutShift.ts b/packages/rum-core/src/domain/view/viewMetrics/trackCumulativeLayoutShift.ts
@@ -1,5 +1,6 @@
 import { round, find, ONE_SECOND, noop } from '@datadog/browser-core'
 import type { RelativeTime } from '@datadog/browser-core'
+import type { WeakRef, WeakRefConstructor } from 'packages/core/src/browser/types'
 import { isElementNode } from '../../../browser/htmlDomUtils'
 import type { LifeCycle } from '../../lifeCycle'
 import { LifeCycleEventType } from '../../lifeCycle'
@@ -13,6 +14,8 @@ export interface CumulativeLayoutShift {
   targetSelector?: string
 }
 
+declare const WeakRef: WeakRefConstructor
+
 /**
  * Track the cumulative layout shifts (CLS).
  * Layout shifts are grouped into session windows.

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -11,7 +11,7 @@
     "sourceMap": true,
 
     "types": [],
-    "lib": ["ES2022", "DOM"],
+    "lib": ["ES2016", "DOM"],
 
     "paths": {
       "@datadog/browser-core": ["./packages/core/src"],