Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build FIPs Image #14

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Build FIPs Image #14

merged 7 commits into from
Nov 25, 2024

Conversation

Copy link

@Fricounet Fricounet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -23,7 +23,7 @@ VERSION?=v1.36.0
PKG=github.com/kubernetes-sigs/aws-ebs-csi-driver
GIT_COMMIT?=$(shell git rev-parse HEAD)
BUILD_DATE?=$(shell date -u -Iseconds)
LDFLAGS?="-X ${PKG}/pkg/driver.driverVersion=${VERSION} -X ${PKG}/pkg/cloud.driverVersion=${VERSION} -X ${PKG}/pkg/driver.gitCommit=${GIT_COMMIT} -X ${PKG}/pkg/driver.buildDate=${BUILD_DATE} -s -w"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't strip the symbol table because we use it to verify crypto libraries

@drewgonzales360 drewgonzales360 merged commit 2396eb4 into datadog Nov 25, 2024
6 checks passed
@drewgonzales360 drewgonzales360 deleted the drew/fips branch November 25, 2024 17:26
datadog-compute-robot pushed a commit that referenced this pull request Dec 12, 2024
* add boring crypto

* Update Makefile

Co-authored-by: Baptiste Girard-Carrabin <[email protected]>

* add verify job

* add fips check

* gotta build bin first

* use a new version of go?

* use the exact version

---------

Co-authored-by: Baptiste Girard-Carrabin <[email protected]>
datadog-compute-robot pushed a commit that referenced this pull request Jan 23, 2025
* add boring crypto

* Update Makefile

Co-authored-by: Baptiste Girard-Carrabin <[email protected]>

* add verify job

* add fips check

* gotta build bin first

* use a new version of go?

* use the exact version

---------

Co-authored-by: Baptiste Girard-Carrabin <[email protected]>
Fricounet added a commit that referenced this pull request Feb 20, 2025
* add boring crypto

* Update Makefile

Co-authored-by: Baptiste Girard-Carrabin <[email protected]>

* add verify job

* add fips check

* gotta build bin first

* use a new version of go?

* use the exact version

---------

Co-authored-by: Baptiste Girard-Carrabin <[email protected]>
datadog-compute-robot pushed a commit that referenced this pull request Mar 6, 2025
* add boring crypto

* Update Makefile

Co-authored-by: Baptiste Girard-Carrabin <[email protected]>

* add verify job

* add fips check

* gotta build bin first

* use a new version of go?

* use the exact version

---------

Co-authored-by: Baptiste Girard-Carrabin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants