-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIAPPS-104 Create a UI Extensions react
package
#94
Merged
joneshf-dd
merged 16 commits into
master
from
hardy.jones/uiapps-104/create-react-package-for-ui-extensions
Jan 25, 2022
Merged
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5dd7e51
UIAPPS-104 Fix UI Extension versions together
joneshf-dd df17b3f
UIAPPS-104 Start a UI Extensions `react` package
joneshf-dd 2e0b4ec
UIAPPS-104 Use the `react` package in examples
joneshf-dd 3be5cfc
UIAPPS-104 Patch the release plan helper
joneshf-dd 94da58a
UIAPPS-104 Don't set `SDK_VERSION`
joneshf-dd 2d7ca54
UIAPPS-104 Don't bundle `react` or the SDK
joneshf-dd 147af1e
UIAPPS-104 Fix starter-kit widget
joneshf-dd 8412100
Merge remote-tracking branch 'origin/master' into hardy.jones/uiapps-…
joneshf-dd b4d6743
UIAPPS-104 Generate API docs for `react` package
joneshf-dd 93759e8
UIAPPS-104 Hack around the lexicographical sorting
joneshf-dd bb85f91
UIAPPS-104 Expand the README a bit more
joneshf-dd a979fdf
UIAPPS-104 Set the metric in `useEffect`
joneshf-dd ba9c1e3
UIAPPS-104 Convert last examples to react package
joneshf-dd 81e7130
Merge branch 'master' into hardy.jones/uiapps-104/create-react-packag…
joneshf-dd 30f57bd
UIAPPS-104 Provide a facade over `useContext`
joneshf-dd f7b5b45
UIAPPS-104 Fix formatting
joneshf-dd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
'@datadog/ui-extensions-react': minor | ||
'@datadog/ui-extensions-sdk': minor | ||
--- | ||
|
||
Create a new package for UI Extensions with the React framework. | ||
|
||
This package provides helpers that make working with the SDK in React a bit easier. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,21 @@ We use [`changesets`][] to help with normal package releases. | |
When a normal PR is merged, [`changsets`][] will keep track of any [changeset][]s in this long-running PR. | ||
When we're ready to release some number of packages, we can merge this long-running PR and [`changesets`][] will release all packages with a [changeset][]. | ||
|
||
## `@datadog/ui-extensions-*` packages | ||
|
||
These packages are all released at the same version. | ||
The intention is to make it so App Developers have an easier time with updates. | ||
If we say, | ||
"Check out this wonderful feature in 0.36.0!" | ||
App Developers should be able to update whatever `@datadog/ui-extensions-*` packages they have to 0.36.0 and be on their way. | ||
|
||
The alternative would be to allow different versions for each package. | ||
That allows more flexibility and lower version churn at the expense of confusion with version updates. | ||
A similar example to the above might be worded like, | ||
"Check out this wonderful feature in 0.36.0 of `@datadog/ui-extensions-sdk`, 2.3.0 of `@datadog/ui-extensions-react`, 1.46.0 of `@datadog/ui-extensions-vue`, etc." | ||
While that's a model that many other groups of packages follow, | ||
we're opting for keeping all the versions the same. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔊 |
||
|
||
[`auto`]: https://intuit.github.io/auto/ | ||
[`changesets`]: https://github.com/changesets/changesets | ||
[changeset]: https://github.com/changesets/changesets/blob/main/docs/detailed-explanation.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
node_modules | ||
coverage | ||
dist |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!