Speed up the conf.d checks #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-rhodes
force-pushed
the
arhodes_faster_conf_check
branch
from
7c5c39e to
a4eb5a4
Compare
alopezz
requested changes
Jul 17, 2024
There was a problem hiding this comment.
👋 Hi, thanks for the PR!
I've tried to test it against a Ubuntu VM, setting datadog_disable_untracked_checks: true and I get this error:
TASK [datadog.datadog : Delete checks not present in agent_datadog_tracked_checks] *****
fatal: [default]: FAILED! => {"msg": "'dict object' has no attribute 'filename'"}
a-rhodes
force-pushed
the
arhodes_faster_conf_check
branch
from
a4eb5a4 to
b2cd71d
Compare
alopezz
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the config options
datadog_disable_untracked_checks,datadog_disable_default_checksordatadog_disable_example_checks, the Ansible run is very slow as it runs a separate task for every directory in theconf.dfolder.Instead, if we change the
findcall to look for conf.yaml* files in the subdirectories, we can filter the results and target specifically what we need, resulting in a much faster role.