Add includepkgs to repo config

[sspans-sbp]

The current repository configuration is unrestricted. Users / patch tooling running the standard yum update command will deploy the latest datadog agent. The recommended configuration of the role is to specify an explicit version, resulting in unfortunate upgrade/downgrade actions.

This PR adds the versioned package as includepkgs to the repository configuration.
This ensures that only the configured version can be installed by yum / dnf.

[mx-psi]

Hey @sspans-sbp thanks for your contribution, could you make sure the CI tests pass? It seems like they are failing on downgrades

[sspans-sbp]

Includepkgs doesn't use the epoch for matching, I've added a jinja filter to strip it from the version string.

[sspans-sbp]

It seems this feature is also supported by zypper, so it makes sense to add it for SuSE as well.

[mx-psi]

LGTM, but I want @bkabrda to have a look too

[sspans-sbp]

Any progress on the review?

[mx-psi]

Any progress on the review?

Hey, my teammate is out of office, so you will have to wait a few more days until he is back (I will remind him, no worries :))

[bkabrda]

Thanks for opening the PR. Overall I think this is a good thing to do, however as noted inline, I can't get the SUSE part to work (I don't think this actually works with zypper). Once we get that sorted out, I can merge.

[sspans-sbp]

I've removed the SuSE bits, please review.

[bkabrda]

LGTM, merging. Thanks for the PR!

[bkabrda]

As a side note, for a while I was deliberating about the fact that some people might actually expect to be able to do plain yum update after running the playbook and get the latest version. I think the reasoning in the description of this PR is valid and its pros (ensuring that the agent flavor/version are always as configured) far outweigh the potential downside, especially considering Ansible's design goal of ensuring that the target machine is put to a certain state.

That said, this new behavior should be documented clearly and explicitly in the release notes for the next release so that users are well informed of its consequences.