Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating docs to v1.5.0 with new features #261

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

jt-dd
Copy link
Contributor

@jt-dd jt-dd commented Sep 12, 2024

Updating docs with new features:

  • deprecation of --cluster flag
  • deprecation of cluster in config file
  • renaming kubehound-ingestor image to kubehound-binary

Fix:

  • typo and syntax

Copy link
Contributor

@Minosity-VR Minosity-VR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little nits

Comment on lines 143 to 146
dynamic:
#
# # Target cluster name
# cluster: <cluster name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commenting out the cluster but not the dynamic keys?
dynamic is optional and could be commented out like ingestor is above no?

docs/dev-guide/getting-started.md Outdated Show resolved Hide resolved
Minosity-VR
Minosity-VR previously approved these changes Sep 12, 2024
@jt-dd jt-dd marked this pull request as ready for review September 12, 2024 15:05
@jt-dd jt-dd requested a review from a team as a code owner September 12, 2024 15:05
@jt-dd jt-dd merged commit 01f384a into main Sep 12, 2024
8 checks passed
@jt-dd jt-dd deleted the jt-dd/update-docs-v1.5.0 branch September 12, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants