[NOJIRA] Use the ParsePath function to gather the cluster name and run ID #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minosity-VR
previously approved these changes
Sep 11, 2024
Co-authored-by: Simon Maréchal <[email protected]>
jt-dd
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been created to resolve #246
I believe some deeper work would be needed to refactor the config loading: it's difficult to know what's the source of truth for some value, and what's populated when.
For example the clustername is set:
Since we are using a pointer to the config in most functions, I believe that consolidating the ClusterName and RunID to be part of the "root" config element would already solve most of the issues.
The question of "when is the data populated" could still be a bit confusing since some code path would populate it at different stage, but I don't see a simple solution for that here.