Better logs #213
Merged
Better logs #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jt-dd
previously approved these changes
Jul 1, 2024
Comment on lines
+75
to
+77
| if clusterName == "" { | ||
| return nil, errors.New("Cluster name is empty. Did you forget to set `KUBECONFIG` or use `kubectx` to select a cluster?") | ||
| } |
There was a problem hiding this comment.
Did you ever got in this situation ? (wondering)
There was a problem hiding this comment.
I did when testing a few thing starting from my personal PC that never connected to k8s.
Co-authored-by: jt-dd <[email protected]>
jt-dd
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add some logs around error handling, fixes some small issues and add some text at the end of ingestion to point to the UI.