Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small fix for system-tests #208

Merged
merged 1 commit into from
Jun 19, 2024
Merged

small fix for system-tests #208

merged 1 commit into from
Jun 19, 2024

Conversation

jt-dd
Copy link
Contributor

@jt-dd jt-dd commented Jun 19, 2024

Create error on conflict for GRPC server in system tests.

edznux-dd
edznux-dd approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@edznux-dd edznux-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the error message explicit enough or should we add a small text mentioning the issue?

@jt-dd
Copy link
Contributor Author

jt-dd commented Jun 19, 2024

Explicit enough: time="2024-06-19T16:06:24+02:00" level=fatal msg="listen tcp 127.0.0.1:9000: bind: address already in use" component=kubehound-ingestor run_id=01j0rd3qpdzcfe0gy6nr19ac3x service=kubehound team=ase

@jt-dd jt-dd marked this pull request as ready for review June 19, 2024 14:20
@jt-dd jt-dd requested a review from a team as a code owner June 19, 2024 14:20
@jt-dd jt-dd merged commit dece49a into main Jun 19, 2024
7 checks passed
@jt-dd jt-dd deleted the jt-dd/fix-grpc-system-tests branch June 19, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edznux-dd edznux-dd edznux-dd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jt-dd @edznux-dd