SSV-22797: Check free thread is running before trying to set memory pressure. (#338) #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira:
SSV-22797: Installation of PSP16 upgrade triggers unexpected BSOD/reboot related to ZFS
Cause:
The Panic was during ZFS driver install/initialize on a VM in Hyper-V. During initialization, new memory allocation failed and then while trying to set the memory pressure, the condition variable spl_free_thread_cv was attempted to be used (which was not yet initialized) and this caused panic.
Fix:
Downstream the PR openzfsonwindows#338.
Checking free thread is running before trying to set the memory pressure.
Test:
Executed ZFS unit test which exercises both the install and memory allocations and all tests passed
http://10.200.2.48:8080/job/OpenZFS-Test-Suite/116
Executed the DCAF ILDC test suites in CI and it passed.
QA: Run DCAF ILDC automation.