Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable sync between new versions of inception and existing repos #60

Conversation

wtfzambo
Copy link
Collaborator

@wtfzambo wtfzambo commented Oct 24, 2024

Fixes #59.


Some context regarding the changes: I found two solutions to address this and both had drawbacks. I chose the one with the least drawback. Specifically:

  • ❌ One solution keeps the template rendering as it was but requires some hacky nonsense to make copier update work properly. The reason is that when you run the update, it goes through the template rendering again. Since it was configured to output everything under a project_name folder, instead of updating the existing repo, it would create a subdirectory with the same name and the diffed files inside of it.
  • ✅ The other solution changes the way the template rendering behaves: instead of generating the project in the project-name subfolder w.r.t. dst_path, it generates it at dst_path. Hence, creating a project folder is in the user's hands. In this case, copier update works as expected.

@wtfzambo wtfzambo linked an issue Oct 24, 2024 that may be closed by this pull request
@wtfzambo wtfzambo changed the title chore: fix update message feat: enable sync between new versions of inception and existing repos Oct 24, 2024
@wtfzambo wtfzambo self-assigned this Oct 25, 2024
@wtfzambo wtfzambo added the enhancement New feature or request label Oct 25, 2024
@wtfzambo wtfzambo marked this pull request as ready for review October 25, 2024 08:07
@wtfzambo wtfzambo requested a review from shahinism October 25, 2024 08:07
@wtfzambo wtfzambo merged commit 4534679 into main Oct 29, 2024
2 checks passed
@wtfzambo wtfzambo deleted the 59-enable-sync-between-new-versions-of-inception-and-existing-repos branch October 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable sync between new versions of Inception and existing repos
2 participants