-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CWL:fix support for user space overrides #2341
Conversation
Build finished. 18 tests run, 0 skipped, 0 failed. |
Build finished. 885 tests run, 39 skipped, 3 failed. |
The failing cwl tests: http://jenkins.cgcloud.info/job/toil-pull-requests/4321/ |
Thank you @DailyDreaming ; turns out that |
@DailyDreaming Looks like the Jenkins-cgcloud-github account also needs its permission adjusted?
http://jenkins.cgcloud.info/job/toil-pull-request-integration-tests/2612/console |
Build finished. 18 tests run, 0 skipped, 0 failed. |
@mr-c Will check on that! |
Build finished. 885 tests run, 39 skipped, 2 failed. |
@mr-c Yes, the permissions need adjusting, but the global jenkins settings need to switch to DataBiosphere, while there are still projects in bd2k that would break if we did that, so we need to separate those two. Will fix that soon, though other things (like the mesos refactor) are higher on the priority list right now. |
Build finished. No test results found. |
1 similar comment
Build finished. No test results found. |
Jenkins, test this please |
Build finished. No test results found. |
Build finished. 18 tests run, 0 skipped, 0 failed. |
http://jenkins.cgcloud.info/job/toil-pull-requests/4329/console |
Jenkins, test this please |
Build finished. 18 tests run, 0 skipped, 0 failed. |
Build finished. 885 tests run, 39 skipped, 0 failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mr-c This looks great. Thanks for the additional refactor/naming too, much appreciated.
Need a release of Toil with DataBiosphere/toil#2341 which isn't in any release yet I don't think.
Actual fix for #2333