Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CWL:fix support for user space overrides #2341

Merged
merged 7 commits into from
Aug 20, 2018
Merged

CWL:fix support for user space overrides #2341

merged 7 commits into from
Aug 20, 2018

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Aug 17, 2018

Actual fix for #2333

@cgcloud-jenkins
Copy link

Build finished. 18 tests run, 0 skipped, 0 failed.

@cgcloud-jenkins
Copy link

Build finished. 885 tests run, 39 skipped, 3 failed.

@DailyDreaming
Copy link
Member

The failing cwl tests: http://jenkins.cgcloud.info/job/toil-pull-requests/4321/

@mr-c
Copy link
Contributor Author

mr-c commented Aug 19, 2018

Thank you @DailyDreaming ; turns out that cwltool didn't have its own tests for the bioconda/biocontainers feature! That failure has been fixed via common-workflow-language/cwltool#874

@ghost ghost assigned mr-c Aug 19, 2018
@ghost ghost added the in progress label Aug 19, 2018
@mr-c
Copy link
Contributor Author

mr-c commented Aug 19, 2018

@DailyDreaming Looks like the Jenkins-cgcloud-github account also needs its permission adjusted?

Using context: jenkins-it
FileNotFoundException means that the credentials Jenkins is using is probably wrong. Or the user account does not have write access to the repo.
org.kohsuke.github.GHFileNotFoundException: {"message":"Not Found","documentation_url":"https://developer.github.com/v3/repos/statuses/#create-a-status"}

http://jenkins.cgcloud.info/job/toil-pull-request-integration-tests/2612/console

@cgcloud-jenkins
Copy link

Build finished. 18 tests run, 0 skipped, 0 failed.

@DailyDreaming
Copy link
Member

@mr-c Will check on that!

@cgcloud-jenkins
Copy link

Build finished. 885 tests run, 39 skipped, 2 failed.

@DailyDreaming
Copy link
Member

@mr-c Yes, the permissions need adjusting, but the global jenkins settings need to switch to DataBiosphere, while there are still projects in bd2k that would break if we did that, so we need to separate those two. Will fix that soon, though other things (like the mesos refactor) are higher on the priority list right now.

@cgcloud-jenkins
Copy link

Build finished. No test results found.

1 similar comment
@cgcloud-jenkins
Copy link

Build finished. No test results found.

@mr-c
Copy link
Contributor Author

mr-c commented Aug 20, 2018

Jenkins, test this please

@cgcloud-jenkins
Copy link

Build finished. No test results found.

@cgcloud-jenkins
Copy link

Build finished. 18 tests run, 0 skipped, 0 failed.

@DailyDreaming
Copy link
Member

No matching distribution found for cwltool==1.0.20180820141117

http://jenkins.cgcloud.info/job/toil-pull-requests/4329/console

@mr-c
Copy link
Contributor Author

mr-c commented Aug 20, 2018

Jenkins, test this please

@cgcloud-jenkins
Copy link

Build finished. 18 tests run, 0 skipped, 0 failed.

@cgcloud-jenkins
Copy link

Build finished. 885 tests run, 39 skipped, 0 failed.

@DailyDreaming DailyDreaming self-requested a review August 20, 2018 23:45
Copy link
Member

@DailyDreaming DailyDreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mr-c This looks great. Thanks for the additional refactor/naming too, much appreciated.

@DailyDreaming DailyDreaming merged commit 9d4b89a into DataBiosphere:master Aug 20, 2018
@ghost ghost removed the in progress label Aug 20, 2018
jmchilton added a commit to galaxyproject/planemo that referenced this pull request Sep 14, 2018
Need a release of Toil with DataBiosphere/toil#2341 which isn't in any release yet I don't think.
@mr-c mr-c deleted the fix_cwl_overrides branch January 30, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants