DT-781: Use logical AND to combine filters in the DUOS UI #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso combine some common code to avoid duplication
pshapiro4broad
requested review from
rjohanek and
cinyecai
and removed request for
a team
pshapiro4broad
commented
Nov 6, 2024
| @@ -104,60 +104,48 @@ export const DatasetSearchTable = (props) => { | |||
| queryChunks.push(...searchModifier); | |||
| } | |||
|
|
|||
| var filterQuery = {}; | |||
| let filterQuery = {}; | |||
There was a problem hiding this comment.
I think var is not recommended now that we have let and const. The difference is that var has function scope, whereas let and const have block scope, which is usually what you want.
pshapiro4broad
commented
Nov 6, 2024
| 'bool': { | ||
| 'must': queryChunks | ||
| } | ||
| return { |
There was a problem hiding this comment.
This change wasn't required, but I thought it would be nice to
- combine the code fragments to avoid duplication
- test
filterQueryinstead of recomputingnumSelectedFilters(filters), sincefilterQueryis the value actually used in the code block
fboulnois
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-781
Users would like filters in the DUOS UI to combine as a set intersection operation, so an item is only shown if it's valid for all selected filters.
Summary
By changing the root node of filter query to use
mustinstead ofshould, the filters are combined using logicalANDinstead ofOR.Video of feature in action
filter.mov