Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-687: Add dynamic warning for users with no institution #2678

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Sep 24, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-687

Summary

Adds a user warning to select an institution we know about. There are three cases here:

User has selected an institution

Screenshot 2024-09-24 at 1 11 35 PM

User has entered a suggested institution

We allow for users to suggest an institution. Currently, there are no backend processes that do anything with this information. At one point, we did, but I believe that has been replaced with the current version when the AffiliationsAndRole component was first introduced.
Screenshot 2024-09-24 at 1 12 19 PM

User has not yet chosen an institution

Screenshot 2024-09-24 at 1 11 22 PM


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review September 24, 2024 18:19
@rushtong rushtong requested a review from a team as a code owner September 24, 2024 18:19
@rushtong rushtong requested review from fboulnois and okotsopoulos and removed request for a team September 24, 2024 18:19
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 👍

@rushtong rushtong merged commit b589591 into develop Sep 26, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-687-institution-warning branch September 26, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants